Skip to content

Autotools: Enable tsrmls cache in hash extension on big endian #15303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

petk
Copy link
Member

@petk petk commented Aug 8, 2024

Unless I'm mistaken and this is disabled intentionally...

When system is detected as big endian this enables the TSRM Local Storage static cache with the ZEND_ENABLE_STATIC_TSRMLS_CACHE compilation flag. Previously it was enabled only on little endian systems.

Pending also GH-15302

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an accident indeed, good catch

When system is detected as big endian this enables the TSRM Local
Storage static cache with the ZEND_ENABLE_STATIC_TSRMLS_CACHE
compilation flag. Previously it was enabled only on little endian
systems.
@petk petk force-pushed the patch-hash-ZEND_ENABLE_STATIC_TSRMLS_CACHE branch from a8c2ef8 to 6bd8209 Compare June 22, 2025 13:23
@petk petk merged commit 4f1b005 into php:master Jun 22, 2025
9 checks passed
@petk petk deleted the patch-hash-ZEND_ENABLE_STATIC_TSRMLS_CACHE branch June 22, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants