ext/gd: imagesetstyle() styles list argument overflow check removal.

devnexen · devnexen · commit 74d177b10bdc · 2025-04-08T22:37:31.000+01:00
Accept up to UINT_MAX * sizeof(int) styles.
diff --git a/ext/gd/gd.c b/ext/gd/gd.c
@@ -648,7 +648,7 @@ PHP_FUNCTION(imagesetstyle)
 	}
 
 	/* copy the style values in the stylearr */
-	stylearr = safe_emalloc(num_styles, sizeof(int), 0);
+	stylearr = emalloc(num_styles * sizeof(int));
 
 	ZEND_HASH_FOREACH_VAL(Z_ARRVAL_P(styles), item) {
 		stylearr[index++] = zval_get_long(item);

Original file line number	Diff line number	Diff line change
`@@ -648,7 +648,7 @@ PHP_FUNCTION(imagesetstyle)`
`648`	`648`	`}`
`649`	`649`
`650`	`650`	`/* copy the style values in the stylearr */`
`651`		`- stylearr = safe_emalloc(num_styles, sizeof(int), 0);`
	`651`	`+ stylearr = emalloc(num_styles * sizeof(int));`
`652`	`652`
`653`	`653`	`ZEND_HASH_FOREACH_VAL(Z_ARRVAL_P(styles), item) {`
`654`	`654`	`stylearr[index++] = zval_get_long(item);`