Skip to content

Commit aa0c54d

Browse files
committed
Merge branch 'PHP-8.4'
* PHP-8.4: Fix prop info fetching from prop slot with added hooks
2 parents 2194ad8 + 6d458ca commit aa0c54d

File tree

3 files changed

+26
-1
lines changed

3 files changed

+26
-1
lines changed

Diff for: Zend/tests/property_hooks/gh18268.phpt

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
--TEST--
2+
GH-18268: array_walk() on object with added property hooks
3+
--FILE--
4+
<?php
5+
6+
class A {
7+
public $prop = 42;
8+
}
9+
10+
class B extends A {
11+
public $prop = 42 {
12+
set {}
13+
}
14+
}
15+
16+
$b = new B;
17+
array_walk($b, function (&$item) {
18+
var_dump($item);
19+
});
20+
21+
?>
22+
--EXPECT--
23+
int(42)

Diff for: Zend/zend_compile.h

+2
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,8 @@ typedef struct _zend_property_info {
467467
((uint32_t)(XtOffsetOf(zend_object, properties_table) + sizeof(zval) * (num)))
468468
#define OBJ_PROP_TO_NUM(offset) \
469469
(((offset) - OBJ_PROP_TO_OFFSET(0)) / sizeof(zval))
470+
#define OBJ_PROP_SLOT_TO_OFFSET(obj, slot) \
471+
((uintptr_t)(slot) - (uintptr_t)(obj))
470472

471473
typedef struct _zend_class_constant {
472474
zval value; /* flags are stored in u2 */

Diff for: Zend/zend_objects_API.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ ZEND_API void ZEND_FASTCALL zend_objects_store_del(zend_object *object) /* {{{ *
203203

204204
ZEND_API ZEND_COLD zend_property_info *zend_get_property_info_for_slot_slow(zend_object *obj, zval *slot)
205205
{
206-
uintptr_t offset = (uintptr_t)slot - (uintptr_t)obj->properties_table;
206+
uintptr_t offset = OBJ_PROP_SLOT_TO_OFFSET(obj, slot);
207207
zend_property_info *prop_info;
208208
ZEND_HASH_MAP_FOREACH_PTR(&obj->ce->properties_info, prop_info) {
209209
if (prop_info->offset == offset) {

0 commit comments

Comments
 (0)