Skip to content

Conversation

@sharadraju
Copy link
Collaborator

Add Oracle AI Database 26ai BOOLEAN column fetch support

@sharadraju
Copy link
Collaborator Author

@shivammathur I am getting some Windows build errors for this PR on the CI pipeline , although the root cause is not clear from the logs. The Linux builds seem to be fine.

The code changes are not platform-specific or even that big.

Can you please look into it and let me know if I need to change anything here?

@shivammathur
Copy link
Member

@sharadraju
Copy link
Collaborator Author

Awesome!
Thanks @shivammathur

@sharadraju sharadraju requested a review from mvorisek January 9, 2026 09:33
["id"]=>
string(1) "2"
["bool_val"]=>
string(1) "0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not return false/true here directly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvorisek for reviewing.
I wanted to keep this similar to #29 and make it consistent.

Any suggestions in the code as to how I can get this to return true/false?
If so, should we make changes for the fix we did for #29 to return true/false as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants