Add apk repository, update debian repository instructions #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will create another pull request to install autocompletion (sh for alpine, bash for deb/rpm) with postinstall scripts after this is merged. Edit: added here. Alpine doesn't have ash autocompletion. |
Contributor
Author
|
CI is only failing to strukturag/libheif#1654. |
Contributor
Author
|
@dunglas @alexandre-daubois sorry for the ping, but could we get this merged? People are currently still installing the old 8.4-only repository that I'm looking to get rid of, as it forces duplicate CI runs. |
Contributor
Author
|
Just pushed another commit because someone had port 2019 in use when installing frankenphp, which means we shouldn't attempt to bind to the admin api as it will fail. |
…ifferent address that doesn't conflict with us
Contributor
Author
|
@alexandre-daubois if you have no objections to the alpine services/install scripts, please merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1753
As per discussion here #2060 (comment) I went ahead with different repos for different php versions. Versioned support with stuff like
apt install frankenphp8.5orapk add frankenphp85are technically also ready, but I'm not running any CI for that yet. I don't think it's worth it at this point as it would double the amount of runs.The old debian repository with only 8.4 is deprecated but will receive updates for a few more months.
Every update/installation will print this notice, though, which will hopefully make everyone aware:
Updated the installer to version 8.5.