[skip-revcheck] Remove empty xi:fallback elements#5699
Conversation
An empty <xi:fallback/> replaces a failed XInclude with nothing, hiding the failure from the reporting configure.php already provides. Continues #274 and the doc-base roadmap (#199). Imagick exception classes are handled separately, they need a content fix to their xpointers. An empty node set is swallowed by libxml 2.15 but surfaces as a failed XInclude on libxml 2.9 (CI), so only CI validates this.
These 11 fallbacks injected an empty <varlistentry> when their include failed, rendering a garbage parameter row instead of surfacing the failure. xinclude_residual_fixup already covers the variablelist parent, so the hand-written net is redundant. The only fallbacks kept are the two inside example CDATA (dom xinclude/getElementsByTagNameNS), which document XInclude.
|
This is very impressive. And also very tasteful (the This was generated by script? If so, then can you publish it somewhere, or can provide a patch file for translations, after this is merged? As |
|
Wow. You even found the xi:fallbacks with inline bodies. Nice! |
jordikroon
left a comment
There was a problem hiding this comment.
I scanned through randomly and don't see anything weird. Also assuming the build will fail if something is wrong so I trust this is alright.
GH CI cannot be really trusted for this, as it does not consider posterior changes on main/master. So an ok result on CI can (and frequently is) completely broken after merge. |
See, for example, on tests of this PR: https://github.com/php/doc-en/actions/runs/29993851297/job/89162721067?pr=5699 In "Checkout php/doc-en" step, we can see
Note that In "Build documentation for en" we can see that doc-en is in I suspect the I did not re-run the tests, to see if it changes anything. If anyone re-runs, and the hashes change, please comment. |
Removes empty
<xi:fallback/>across doc-en, turning<xi:include ...><xi:fallback/></xi:include>into<xi:include .../>.An empty fallback replaces a failed XInclude with nothing, hiding the failure
from the reporting
configure.phpalready gives.The two
<xi:fallback>inside example CDATA (domxinclude/getElementsByTagNameNS) are kept, they document the feature itself.Related:
[skip-revcheck]: no translated content affected.