Add translatable acronym entities#5695
Merged
Merged
Conversation
This was referenced Jul 21, 2026
lacatoire
reviewed
Jul 22, 2026
lacatoire
approved these changes
Jul 22, 2026
Member
|
I may move the acronyms definitions in this file, from doc-base/entities/global.ent, as all definitions and expansions to reside in one place. Also, I suggest rename the file doc-en/entities/acronyms.ent to doc-en/entities/entities.acronyms.ent (as all entities.*.ent files are ordered nearby, this folder may have many other files, see text-entities.php). |
Remove the 79-column line length restriction from the file header and consolidate multi-line acronym definitions onto single lines for improved readability and maintainability. Also fix the capitalization of "eXtensible" to "Extensible" in the XSLT entity definition for consistency.
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
jordikroon
force-pushed
the
translatable-acronyms
branch
from
July 22, 2026 19:33
2cb0844 to
16ba6e8
Compare
alfsb
approved these changes
Jul 23, 2026
alfsb
left a comment
alfsb
left a comment
Member
There was a problem hiding this comment.
I think this can be merged first, and then PhD and doc-base in order.
Member
Author
|
This has been merged. Will leave PhD & doc-base open for a few days before merging both sequentially. If you have any feedback, please add them to PhD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @alfsb
Moving Acronyms from doc-base to doc-en. This allows Acronyms to be translated, as well as to more easily phase out unused acronyms.
This is a set of 3 PRs
doc-en: #5695 (you are here)
doc-base: php/doc-base#325
phd: php/phd#262