Sync newly added parameters #5074
Conversation
|
The OpenSSL part LGTM |
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Please use <simpara> instead of <para> where able, and create an XML entity for the locale parameter and changelog of the Grapheme functions.
| <term><parameter>uriParserClass</parameter></term> | ||
| <listitem> | ||
| <simpara> | ||
| The classname to use for parsing the redirection URI when a "Location" header is received in the response, |
There was a problem hiding this comment.
Maybe?
| The classname to use for parsing the redirection URI when a "Location" header is received in the response, | |
| The classname to use for parsing the redirection URI when a <literal>"Location"</literal> header is received in the response, |
| <tbody> | ||
| <row> | ||
| <entry>8.5.0</entry> | ||
| <entry><methodname>SoapFault::__construct</methodname> now also expects <parameter>lang</parameter>.</entry> |
There was a problem hiding this comment.
| <entry><methodname>SoapFault::__construct</methodname> now also expects <parameter>lang</parameter>.</entry> | |
| <entry> | |
| The optional parameter <parameter>lang</parameter> has been added. | |
| </entry> |
There was a problem hiding this comment.
Perhaps this changelog entry (and the other one) should describe this was necessary to be compliant to the SOAP 1.2 spec. This is what made me add this, otherwise communicating between e.g. PHP & .NET was difficult.
| <tbody> | ||
| <row> | ||
| <entry>8.5.0</entry> | ||
| <entry><methodname>SoapServer::fault</methodname> now also expects <parameter>lang</parameter>.</entry> |
There was a problem hiding this comment.
| <entry><methodname>SoapServer::fault</methodname> now also expects <parameter>lang</parameter>.</entry> | |
| <entry> | |
| The optional parameter <parameter>lang</parameter> has been added. | |
| </entry> |
| <varlistentry> | ||
| <term><parameter>lang</parameter></term> | ||
| <listitem> | ||
| <simpara/> |
There was a problem hiding this comment.
@ndossche could you provide a description of the new parameter?
There was a problem hiding this comment.
SoapFaults in SOAP version 1.2 have a language attribute describing the (human) language that the SoapFault is written in.
So I'd describe it as follows:
The human language that the SoapFault is written in. This is only used for SOAP version 1.2.
| <varlistentry> | ||
| <term><parameter>lang</parameter></term> | ||
| <listitem> | ||
| <simpara/> |
| <varlistentry> | ||
| <term><parameter>digest_algo</parameter></term> | ||
| <listitem> | ||
| <simpara>The digest algorithm for OEAP padding, or &null; to use the default algorithm.</simpara> |
There was a problem hiding this comment.
Nit
| <simpara>The digest algorithm for OEAP padding, or &null; to use the default algorithm.</simpara> | |
| <simpara> | |
| The digest algorithm for OEAP padding, or &null; to use the default algorithm. | |
| </simpara> |
| <varlistentry> | ||
| <term><parameter>digest_algo</parameter></term> | ||
| <listitem> | ||
| <simpara>The digest algorithm for OEAP padding, or &null; to use the default algorithm.</simpara> |
There was a problem hiding this comment.
| <simpara>The digest algorithm for OEAP padding, or &null; to use the default algorithm.</simpara> | |
| <simpara> | |
| The digest algorithm for OEAP padding, or &null; to use the default algorithm. | |
| </simpara> |
| <row> | ||
| <entry>8.5.0</entry> | ||
| <entry> | ||
| <function>openssl_private_decrypt</function> now also accepts <parameter>digest_algo</parameter>. |
There was a problem hiding this comment.
| <function>openssl_private_decrypt</function> now also accepts <parameter>digest_algo</parameter>. | |
| The optional parameter <parameter>digest_algo</parameter> has been added. |
| <row> | ||
| <entry>8.5.0</entry> | ||
| <entry> | ||
| <function>openssl_public_encrypt</function> now also accepts <parameter>digest_algo</parameter>. |
There was a problem hiding this comment.
| <function>openssl_public_encrypt</function> now also accepts <parameter>digest_algo</parameter>. | |
| The optional parameter <parameter>digest_algo</parameter> has been added. |
| <row> | ||
| <entry>8.5.0</entry> | ||
| <entry> | ||
| <function>grapheme_substr</function> now also accepts <parameter>locale</parameter>. | ||
| </entry> | ||
| </row> |
There was a problem hiding this comment.
And make this whole row tag an XML entity to reuse across all the grapheme functions with the new param.
| <row> | |
| <entry>8.5.0</entry> | |
| <entry> | |
| <function>grapheme_substr</function> now also accepts <parameter>locale</parameter>. | |
| </entry> | |
| </row> | |
| <row> | |
| <entry>8.5.0</entry> | |
| <entry> | |
| The optional parameter <parameter>locale</parameter> has been added. | |
| </entry> | |
| </row> |
4 participants
No description provided.