Add new 8.4 DateTime functions #5070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordikroon
reviewed
Jan 2, 2026
Girgias
requested changes
Jan 9, 2026
| <refentry xml:id="datetimeimmutable.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <refnamediv> | ||
| <refname>DateTimeImmutable::createFromTimestamp</refname> | ||
| <refpurpose>Returns new DateTimeImmutable object representing given Unix timestamp</refpurpose> |
Member
There was a problem hiding this comment.
Maybe?
Suggested change
| <refpurpose>Returns new DateTimeImmutable object representing given Unix timestamp</refpurpose> | |
| <refpurpose>Creates an instance from a Unix timestamp</refpurpose> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Documentation tracker #3872
Adding new
DateTimefunctions added in8.4createFromTimestampaccepts some timestamp values belowPHP_INT_MIN(untilPHP_INT_MIN - 1024, see related tests).Since returned date are all the same for this specific values, I think it may be an error, because it doesn't throw any exception.
I'm not sure if we should document the actual bogus behavior, to prevent anyone to rely on this 🤔
Also:
Then, no offense if you think it can be improved 🙂
Thanks for your huge work, happy if this PR can help 🙇