Add warnings about numeric strings in scientific notation #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jan 27, 2025
Comment on lines
+88
to
+103
| <warning> | ||
| <simpara> | ||
| When using the <link linkend="language.operators.comparison">comparison | ||
| operator (<literal>==</literal>)</link>, | ||
| <link linkend="language.types.numeric-strings">numeric strings</link> | ||
| will be compared as numbers instead of as strings. | ||
| This means that <literal>"123" == " 123 "</literal> is &true;, | ||
| but also that <literal>"0e1234" == "0e5678"</literal> is &true;, | ||
| which can cause unexpected behavior when comparing hexidecimal strings | ||
| like those from <function>hash</function>. | ||
| The identity operator (<literal>===</literal>) or a string comparison | ||
| function, such as <function>strcmp</function> or | ||
| <function>hash_compare</function>, should be used to avoid unexpected | ||
| results. | ||
| </simpara> | ||
| </warning> |
There was a problem hiding this comment.
This should be in the comparative type juggling section, not the string one.
|
Isn't this all well-documented already? This foothole is probably as old as PHP and one the first things you learn. The documentation is pretty clear about the string comparison https://www.php.net/manual/en/language.operators.comparison.php I am not against clarifying something that's unclear, but I don't know if adding another red box is truly necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spurred by discussions here: https://masto.brightfur.net/@IceWolf/113846808339270184