Move iterator methods of SimpleXMLIterator to SimpleXMLElement

[kocsismate]

php/php-src#5234

[cmb69]

Thanks for tackling this! (this PR would fix #1640 and #1784)

I'm not quite sure how to handle that method pull-up. Do we need comprehensive changelog entries? What to do with versions.xml (currently, the methods are still listed for SimpleXMLIterator there)? Should we add "alias" like pages for the old methods on SimpleXMLIterator? Or just as YOLO as in #2136?

[kocsismate]

I'm not quite sure how to handle that method pull-up. Do we need comprehensive changelog entries? What to do with versions.xml (currently, the methods are still listed for SimpleXMLIterator there)? Should we add "alias" like pages for the old methods on SimpleXMLIterator? Or just as YOLO as in #2136?

Yes, I had similar questions, and was hoping to get the answers from you 😅 But anyway, here are my ideas:

• we could add a changelog entry to SimpleXMLElement that the methods in questions were moved from the iterator. IMO we don't need a changelog for SimpleXMLIterator because there is no change from its perspective
• I'm not sure about version.xml.. I probably lean towards documenting the actual value (PHP 8). Maybe we could display a nice warning message on these pages that these methods were moved and they are available on the iterator since PHP 5.
• My plan is to add a web-php redirection from SimpleXMLIterator to SimpleXMLElement.

[Girgias]

The throw an error shouldn't be mentioned in the return section but in a standard new Error section.

[Girgias]

Suggested change

	Before PHP 8.0, <methodname>SimpleXMLElement::current</methodname> was declared on
	<classname>SimpleXMLIterator</classname>, available as of PHP 5.
	Prior to PHP 8.0, <methodname>SimpleXMLElement::current</methodname> was only
	declared on the subclass <classname>SimpleXMLIterator</classname>.

[kocsismate]

I think I managed to address the feedback in a new commit (+ rebased to current master)