Narrow parameter type for antispambot() #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrows
$hex_encoding
fromint
to0|1
forantispambot()
.While passing integers other than
0
(default) or1
does not trigger PHP or WordPress errors, it expands the random rangerand(0, 1 + $hex_encoding)
, allowing values (e.g.3
) that hit no branch and therefore omit characters.-1
would preserve correct email addresses, but since the parameter description says:it has been narrowed to
0|1
.