Enabled dynamic datacallbacks #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return $this->viewModel; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| protected function getItems(DataTable $dataTable, $offset, $limit) |
There was a problem hiding this comment.
Looking good :). I think this method with its content could also be in the AbstractAdapter. The filterItems method can also be in the AbstractAdapter, but without using array_values. Then you will need to override filterItems because datatables expects an indexed array.
| * | ||
| * @return ColumnBag | ||
| */ | ||
| public function setDataCallback($column, \Closure $callback) |
There was a problem hiding this comment.
I wouldn't typehint \Closure here. If you do, you disallow things like array($myObject, 'someMethod'). Do no typehint + is_callable check instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to comment again ;)