fix build warning #417

remicollet · 2018-12-21T13:25:14Z

/work/GIT/php-memcached/php_memcached.c: In function 's_stat_execute_cb':
/work/GIT/php-memcached/php_memcached.c:2755:27: warning: field precision specifier '.*' expects argument of type 'int', but argument 4 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
  spprintf (&buffer, 0, "%.*s", value_length, value);
                         ~~^~   ~~~~~~~~~~~~

sodabrew · 2018-12-22T01:02:41Z

php_memcached.c

@@ -2752,7 +2752,7 @@ memcached_return s_stat_execute_cb (php_memcached_instance_st instance, const ch
 		server_values = zend_hash_add(Z_ARRVAL_P(return_value), server_key, &zv);
 	}

-	spprintf (&buffer, 0, "%.*s", value_length, value);
+	spprintf (&buffer, 0, "%.*s", (int)value_length, value);


In theory, this needs to be clamped to INT_MAX for safety. In practice a number that large (or negative wraparound!) won't happen or will crash elsewhere anyways.

fix build warning

48247e5

sodabrew reviewed Dec 22, 2018

View reviewed changes

sodabrew added this to the 3.1.1 milestone Dec 22, 2018

sodabrew merged commit 3529243 into php-memcached-dev:master Dec 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix build warning #417

fix build warning #417

remicollet commented Dec 21, 2018 •

edited

Loading

sodabrew Dec 22, 2018

fix build warning #417

fix build warning #417

Conversation

remicollet commented Dec 21, 2018 • edited Loading

sodabrew Dec 22, 2018

Choose a reason for hiding this comment

remicollet commented Dec 21, 2018 •

edited

Loading