Only throw deprecation when user explicitly sets option #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Apr 5, 2017
| @@ -338,7 +338,7 @@ private function configureOptions(OptionsResolver $resolver) | |||
| 'cache_lifetime' => 86400 * 30, // 30 days | |||
| 'default_ttl' => 0, | |||
| //Deprecated as of v1.3, to be removed in v2.0. Use respect_response_cache_directives instead | |||
| 'respect_cache_headers' => true, | |||
| 'respect_cache_headers' => null, | |||
There was a problem hiding this comment.
You do also have to add "null" as an allowed type.
acrobat
force-pushed
the
deprecation-notice-fix
branch
from
e7f36e6 to
a1c0b7d
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This pr fixes the issue so the deprecation notice is only throw when the users sets the "respect_cache_headers" option.