Phpstan level 6 #307
Draft
Phpstan level 6 #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnix
commented
May 2, 2025
devnix
commented
May 3, 2025
| @@ -51,9 +61,7 @@ public function delete(string ...$comments): self | |||
| foreach ($comments as $comment) { | |||
| $key = array_search($comment, $this->comments); | |||
|
|
|||
| if (is_int($key)) { | |||
There was a problem hiding this comment.
My previous question was more related to this change.
As far as I understand, should Comments::$comments be an array of integer keys only? If that is correct, this condition would be unnecessary :)
There was a problem hiding this comment.
$key can be false, if the comment wasn't found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #306