Skip to content

Treat "-0" as "0" #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Treat "-0" as "0" #67

wants to merge 1 commit into from

Conversation

julienfalque
Copy link

Fixes #66.

julienfalque
julienfalque commented Feb 20, 2022
View reviewed changes
@rtheunissen
Copy link
Contributor

Thank you so much for this patch. I'll take a look this week and try my best to merge it.

@julienfalque julienfalque mentioned this pull request Feb 21, 2022
Merged
@julienfalque
Treat "-0" as "0"
4dd5ff9 
"0" and "-0" are mathematically identical so it should they should
treated as the same value.

Zero is considered neither positive nor negative, so `isPositive()` and
`isNegative()` both return `false`. This is consistent with `signum()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheunissen rtheunissen rtheunissen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienfalque @rtheunissen