Own benchmark workers and reject invalid results - #9
Closed
jeregrine wants to merge 1 commit into
Closed
Conversation
jeregrine
force-pushed
the
fix/benchmark-correctness
branch
from
September 10, 2026 12:49
6f4a750 to
102d755
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local benchmark workers sleep forever without a scenario owner. Stopping Group does not stop those workers, so later scenarios inherit an increasingly large process population. Operation results are ignored, and event-delivery timeouts merely print a warning before reporting throughput for all expected events.
Fix
Give each scenario a worker supervisor and synchronously stop its workers on success or failure. Provision workers before releasing the measured workload so supervisor startup does not become a serial throughput bottleneck.
Require successful operation results, detect worker exits and timeouts, verify registry and membership datasets, and validate each read sample outside its timed interval. Event delivery requires the exact expected registrations, rejecting missing, duplicate, or incorrect events instead of reporting partial work as success.
Add a standalone harness regression suite covering resource ownership, failure paths, cluster-scoped verification, and event validation. Remove monitor subscriptions before teardown so Registry shutdown does not require swallowing exit signals.
Supporting information
Write timings now exclude worker provisioning; event timings include exact event validation. Existing throughput figures are not directly comparable: establish a fresh baseline with the corrected harness.
This change affects the local benchmark harness only. It adds no runtime dependencies and does not change Group's production implementation.