feat: highcyclearea interface change#798
Open
Alexander Pärsch (uxitraAlex) wants to merge 7 commits intophilips-software:mainfrom
Open
feat: highcyclearea interface change#798Alexander Pärsch (uxitraAlex) wants to merge 7 commits intophilips-software:mainfrom
Alexander Pärsch (uxitraAlex) wants to merge 7 commits intophilips-software:mainfrom
Conversation
…etter checks for not continouse range and different memory range then available sectors.
Contributor
Fabian Gottstein (fabiangottstein)
left a comment
Fabian Gottstein (fabiangottstein)
left a comment
There was a problem hiding this comment.
For completeness, could you also create a SynchronousFlashInternalHighCycleAreaStm ?
Alexander Pärsch (uxitraAlex)
changed the title
Alexander Pärsch (uxitraAlex)
changed the title
| explicit WithIrqHandler(HalfWordRange flashMemory); | ||
| }; | ||
|
|
||
| class SynchronousFlashInternalHighCycleAreaStm |
Contributor
There was a problem hiding this comment.
please move to to synchronous_stm32fxxx directory.
This class should also have an WithIrqHandler sub class. (see SynchronousOneTimeProgrammableFlashStm.hpp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.