Add google/re2 and abseil-cpp as external dependencies#336
Draft
Copilot wants to merge 10 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/0e3cf009-a2d6-49bc-bf3e-dd63ff740acd Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Daan Timmer (daantimmer)
May 13, 2026 07:08
View session
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. No release type found in pull request title "Add google/re2 and abseil-cpp as external dependencies". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
|
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 6 | 0 | 0 | 0.04s | |
| ✅ CPP | clang-format | 239 | 3 | 0 | 0 | 1.77s |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.04s | |
| markdownlint | 7 | 4 | 19 | 0 | 1.19s | |
| ✅ MARKDOWN | markdown-table-formatter | 7 | 4 | 0 | 0 | 0.32s |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.03s | |
| ✅ REPOSITORY | grype | yes | no | no | 42.59s | |
| ✅ REPOSITORY | ls-lint | yes | no | no | 0.13s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 4.74s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.76s | |
| ✅ REPOSITORY | trivy | yes | no | no | 11.83s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.26s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 5.74s | |
| lychee | 86 | 1 | 0 | 4.68s | ||
| ✅ YAML | prettier | 10 | 0 | 0 | 0 | 0.76s |
| ✅ YAML | v8r | 10 | 0 | 0 | 8.55s | |
| ✅ YAML | yamllint | 10 | 0 | 0 | 0.59s |
Detailed Issues
⚠️ SPELL / lychee - 1 error
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
📝 Summary
---------------------
🔍 Total..........169
✅ Successful.....168
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
Errors in CONTRIBUTING.md
[404] https://github.com/yourname/amp-cucumber-cpp-runner.git | Network error: Not Found
⚠️ MARKDOWN / markdownlint - 19 errors
CHANGELOG.md:31 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:37 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:44 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:51 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:59 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:63 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:72 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:78 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:86 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:90 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:95 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:104 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:115 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
CHANGELOG.md:123 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:127 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:152 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:159 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Chores"]
cmake/WindowsToolchainFilesProvidedBy.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "<https://github.com/MarkSchofi..."]
README.md:114 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
Collaborator
|
Copilot resolve the cmake configure issues |
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/9f30db49-b4ba-4e81-8e79-9526f60101d5 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
Contributor
Author
Fixed in d625ab2. The issue was that re2's |
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/40e20c8b-1421-4d1f-867d-fb4e29d1b994 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/40e20c8b-1421-4d1f-867d-fb4e29d1b994 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/40e20c8b-1421-4d1f-867d-fb4e29d1b994 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
…n conflict Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/7bb1f5cc-0fbc-4d37-b19a-d7d70116d3cd Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
…plementations Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/e62df561-2d9b-48d9-9306-405d1d941bb1 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
…nvalid-pattern test Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/e62df561-2d9b-48d9-9306-405d1d941bb1 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
…d tests Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/9823874c-5558-4d0a-bb90-309e7c61d636 Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,36 @@ | |||
| #include "cucumber_cpp/library/cucumber_expression/Re2RegexStrategy.hpp" | |||
| #include <re2/re2.h> | |||
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| #include <re2/re2.h> |
| #include "cucumber_cpp/library/cucumber_expression/Re2RegexStrategy.hpp" | ||
| #include <re2/re2.h> | ||
| #include <optional> | ||
| #include <stdexcept> |
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
| #include <stdexcept> | |
| #include <re2/re2.h> | |
| #include <stdexcept> |
| @@ -0,0 +1,2 @@ | |||
| // This file has been superseded by StdRegexStrategy.cpp and Re2RegexStrategy.cpp. | |||
|
|
|||
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
Agent-Logs-Url: https://github.com/philips-software/amp-cucumber-cpp-runner/sessions/1d5dafd2-6ab6-4e4e-9b8d-4c8f6f07386c Co-authored-by: daantimmer <8293597+daantimmer@users.noreply.github.com>
| } | ||
| #endif | ||
| } | ||
|
|
There was a problem hiding this comment.
[MegaLinter] reported by reviewdog 🐶
Suggested change
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCR_USE_RE2cmake option (defaults toCCR_DEFAULTOPT)CCR_USE_RE2inexternal/google/CMakeLists.txtTARGET re2::re2in top-level CMakeLists and setCCR_HAS_RE2cucumber_expression/CMakeLists.txt: conditionally compileRe2RegexStrategy, linkre2::re2, and propagateCCR_HAS_RE2compile definitionRegexStrategyFactory.hpp/RegexStrategyFactory.cppfactory returningunique_ptr<RegexStrategy>(Re2 when available, Std otherwise)TestRegexStrategy.cppRe2-specific tests with#ifdef CCR_HAS_RE2TestRegexStrategyFactory.cppwith tests for the factorytest/CMakeLists.txtto includeTestRegexStrategyFactory.cppCCR_USE_RE2=OnandCCR_USE_RE2=Offpass all tests)