Skip to content

Improved warning UX for bad asset cases + generated icon #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CianNoonan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improved warning UX for bad asset cases + generated icon #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b945a4c
Improved the warning generation to give more artist friendly info. Al…
CianNoonan May 21, 2020
868fe3b
The generated texture is now the icon for the asset as is the case wi…
CianNoonan May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Editor/SmartTextureImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,8 @@ public override void OnImportAsset(AssetImportContext ctx)

ApplyPropertiesViaSerializedObj(texture);
}

//If we pass the tex to the 3rd arg we can have it show in an Icon as normal, maybe configurable?
//ctx.AddObjectToAsset("mask", texture, texture);
ctx.AddObjectToAsset("mask", texture);

ctx.AddObjectToAsset("mask", texture, texture);
ctx.SetMainObject(texture);
}

Expand Down
29 changes: 24 additions & 5 deletions Runtime/TextureChannelPacker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ private static Material packChannelMaterial
}
}

static bool CompressedTextureFormat(TextureFormat format)
{
//There should be a much better way to work this out, this might not even be an exhaustive list :(
return format == TextureFormat.BC4
|| format == TextureFormat.BC5
|| format == TextureFormat.BC6H
|| format == TextureFormat.BC7
|| format == TextureFormat.DXT1
|| format == TextureFormat.DXT1Crunched
|| format == TextureFormat.DXT5
|| format == TextureFormat.DXT5Crunched;
}
public static void PackChannels(this Texture2D mask, Texture2D[] textures, TexturePackingSettings[] settings = null, bool generateOnGPU = true)
{
if (textures == null || textures.Length != 4)
Expand All @@ -58,24 +70,31 @@ public static void PackChannels(this Texture2D mask, Texture2D[] textures, Textu
int width = mask.width;
int height = mask.height;
int pixelCount = width * height;
bool invalidTextures = false;

foreach (Texture2D t in textures)
for (int i = 0; i < textures.Length; i++)
{
var t = textures[i];
if (t != null)
{
if (!generateOnGPU && !t.isReadable)
{
Debug.LogError(t + " texture is not readable. Toogle Read/Write Enable in texture importer. ");
return;
Debug.LogError($"SmartTexture Aborting: {t.name} texture is not readable so we cannot import on CPU. Toogle Read/Write Enable in texture importer. ", t);
invalidTextures = true;
}

if (t.width != width || t.height != height)
{
Debug.LogError(t + " input textures must have the same size.");
return;
Debug.LogWarning($"SmartTexture: {t.name} does not match expected size. This can cause artfacts as the texture will be sampled onto a different size target, mismatches are not advised", t);
}

if (CompressedTextureFormat(t.format))
{
Debug.LogWarning($"SmartTexture: {t.name} is already compressed, channel {i} will be double compressed. Please use an uncompressed format, input texture size isn't relevant to the build", t);
}
}
}
if (invalidTextures) return;

if (generateOnGPU)
{
Expand Down