Repository navigation
Conversation
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebGLSpriteBatchchecked the globalPIXI._enableMultiTextureTogglein its per-sprite hot paths, so the multi-texture and single-texture invariants were interleaved inrender,renderTilingSpriteandflush. This PR splits the two modes. It is a refactor with no intended behavior change.Strategy chosen once in
setContextthis.multiTextureand assignsdefaultShader,bindTextureanduploadTexturefor the active mode.createMultiTextureShader/createSingleTextureShader,bindTextureMulti/bindTextureSingle(single is a no-op),uploadTextureMulti/uploadTextureSingle.Hot paths
renderandrenderTilingSpritecallthis.bindTexture(baseTexture, textureIndex). This removes the duplicated bind-and-flush block between them.flushreadsthis.multiTextureinstead of the global.TileSprite_renderWebGLnow callsspriteBatch.uploadTexture(...).Not changed
PixiShader,StripShader,PixiFastShader,Creature,DisplayObjectandWebGLRenderer#setTexturePrioritystill readPIXI._enableMultiTextureToggledirectly.PIXI._enableMultiTextureToggleand theGameconfig are unchanged.renderBatchstill calls a plaingl.bindTexturewith noactiveTexture. I suspect this is fine in multi-texture mode because the batch shader samples by index, but it is unverified.Review focus
multiTexture: falseandtruecovering sprites, tiling sprites (including texture regeneration), filters, strips, Creature andsetTexturePriority.bindTextureanduploadTextureare undefined untilsetContextruns. All current callers run after context setup.