Merge pull request #1890 from Ducasse/FixingReleaseTests

Removing dead code
pharo-vcs · Jan 30, 2025 · cc64c72 · cc64c72
2 parents 78ab3ca + 5e174d5
commit cc64c72
Show file tree

Hide file tree

Showing 14 changed files with 25 additions and 38 deletions.
diff --git a/Iceberg-Playground-Plugin-Gist/IcePublishGistPresenter.class.st b/Iceberg-Playground-Plugin-Gist/IcePublishGistPresenter.class.st
@@ -21,17 +21,11 @@ Class {
 }
 
 { #category : 'accessing' }
-IcePublishGistPresenter class >> initialExtent [
+IcePublishGistPresenter class >> defaultPreferredExtent [
 
 	^ 600@400
 ]
 
-{ #category : 'accessing' }
-IcePublishGistPresenter class >> windowTitle [
-
-	^ 'Publish Gist'
-]
-
 { #category : 'accessing' }
 IcePublishGistPresenter >> content: aString [
 
@@ -88,14 +82,6 @@ IcePublishGistPresenter >> initializePresenters [
 		beForScripting
 ]
 
-{ #category : 'initialization' }
-IcePublishGistPresenter >> initializeWindow: aWindowPresenter [
-
-	aWindowPresenter 
-		title: self class windowTitle;
-		initialExtent: self class initialExtent.
-]
-
 { #category : 'actions' }
 IcePublishGistPresenter >> publishThen: aBlock [
 	| description public jsonResult |
@@ -143,3 +129,9 @@ IcePublishGistPresenter >> whenPublishedDo: aBlock [
 
 	publishedAction := aBlock
 ]
+
+{ #category : 'events' }
+IcePublishGistPresenter >> windowTitle [
+
+	^ 'Publish Gist'
+]
diff --git a/Iceberg-Plugin-GitHub/IceTipRefreshPullRequestsCommand.class.st b/Iceberg-Plugin-GitHub/IceTipRefreshPullRequestsCommand.class.st
@@ -35,7 +35,7 @@ IceTipRefreshPullRequestsCommand >> execute [
 { #category : 'accessing' }
 IceTipRefreshPullRequestsCommand >> iconName [
 
-	^ #glamorousRefresh
+	^ #refresh
 ]
 
 { #category : 'accessing' }

diff --git a/Iceberg-TipUI/IceTipAbstractCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAbstractCredentialsPresenter.class.st
@@ -109,8 +109,10 @@ IceTipAbstractCredentialsPresenter >> hostnameFromInput [
 
 { #category : 'initialization' }
 IceTipAbstractCredentialsPresenter >> initialize [
+	askingHostname := 'default host name'.
 	super initialize.
-	accepted := false
+	accepted := false.
+
 ]
 
 { #category : 'initialization' }

diff --git a/Iceberg-TipUI/IceTipCreateTagCommand.class.st b/Iceberg-TipUI/IceTipCreateTagCommand.class.st
@@ -42,5 +42,5 @@ IceTipCreateTagCommand >> execute [
 { #category : 'activation' }
 IceTipCreateTagCommand >> iconName [
 
-	^ #glamorousBookmark
+	^ #bookmark
 ]
diff --git a/Iceberg-TipUI/IceTipCritiquesBeforeCommitBrowser.class.st b/Iceberg-TipUI/IceTipCritiquesBeforeCommitBrowser.class.st
@@ -204,7 +204,7 @@ IceTipCritiquesBeforeCommitBrowser >> initializePresenters [
 	browseButton := self newButton.
 	browseButton label: 'Browse Entity'.
 	browseButton action: (MessageSend receiver: self selector: #doBrowse).
-	browseButton icon: (self iconNamed: #glamorousBrowse).
+	browseButton icon: (self iconNamed: #browse).
 
 	autofixButton := self newButton.
 	autofixButton label: 'Autofix'.

diff --git a/Iceberg-TipUI/IceTipInspectCommand.class.st b/Iceberg-TipUI/IceTipInspectCommand.class.st
@@ -36,5 +36,5 @@ IceTipInspectCommand >> execute [
 { #category : 'accessing' }
 IceTipInspectCommand >> iconName [
 
-	^ #glamorousInspect
+	^ #inspect
 ]
diff --git a/Iceberg-TipUI/IceTipPresenter.class.st b/Iceberg-TipUI/IceTipPresenter.class.st
@@ -44,12 +44,6 @@ IceTipPresenter >> decorations [
 	^ decorations ifNil: [ decorations := self class buildDecorations ]
 ]
 
-{ #category : 'initialization' }
-IceTipPresenter >> setInitialExtentTo: aSpWindowPresenter [
-
-	aSpWindowPresenter initialExtent: self initialExtentForWindow
-]
-
 { #category : 'extensions' }
 IceTipPresenter >> updateTitle [
 

diff --git a/Iceberg-TipUI/IceTipRefreshCommitCommand.class.st b/Iceberg-TipUI/IceTipRefreshCommitCommand.class.st
@@ -33,7 +33,7 @@ IceTipRefreshCommitCommand >> execute [
 { #category : 'accessing' }
 IceTipRefreshCommitCommand >> iconName [
 
-	^ #glamorousRefresh
+	^ #refresh
 ]
 
 { #category : 'accessing' }

diff --git a/Iceberg-TipUI/IceTipRemoveFromRepositoryPackageCommand.class.st b/Iceberg-TipUI/IceTipRemoveFromRepositoryPackageCommand.class.st
@@ -30,5 +30,5 @@ IceTipRemoveFromRepositoryPackageCommand >> execute [
 { #category : 'accessing' }
 IceTipRemoveFromRepositoryPackageCommand >> iconName [
 
-	^ #glamorousTrash
+	^ #trash
 ]
diff --git a/Iceberg-TipUI/IceTipRepairLocateRepository.class.st b/Iceberg-TipUI/IceTipRepairLocateRepository.class.st
@@ -27,7 +27,7 @@ This happens if the repository has been removed from the disk or the image was p
 
 { #category : 'accessing' }
 IceTipRepairLocateRepository class >> icon [
-	^ self iconNamed: #glamorousFolder
+	^ self iconNamed: #folder
 ]
 
 { #category : 'testing' }

diff --git a/Iceberg-TipUI/IceTipRepositoryModel.class.st b/Iceberg-TipUI/IceTipRepositoryModel.class.st
@@ -418,7 +418,7 @@ IceTipRepositoryModel >> repositoryModelsByGroup [
 		  "Tags group"
 		  ((IceTipTreeRepositoryGroup on: self)
 			   name: 'Tags';
-			   iconFormSet: (self iconFormSetNamed: #glamorousBookmark);
+			   iconFormSet: (self iconFormSetNamed: #bookmark);
 			   children: (tags collect: [ :each | IceTipTreeTag on: each ]);
 			   yourself) }
 	"Branches group"

diff --git a/Iceberg-TipUI/IceTipUnloadAndRemovePackageCommand.class.st b/Iceberg-TipUI/IceTipUnloadAndRemovePackageCommand.class.st
@@ -46,5 +46,5 @@ IceTipUnloadAndRemovePackageCommand >> execute [
 { #category : 'accessing' }
 IceTipUnloadAndRemovePackageCommand >> iconName [
 
-	^ #glamorousTrash
+	^ #trash
 ]
diff --git a/Iceberg-UI-Tests/IceTipAskForPlaintextCredentialsModelTest.class.st b/Iceberg-UI-Tests/IceTipAskForPlaintextCredentialsModelTest.class.st
@@ -160,5 +160,5 @@ IceTipAskForPlaintextCredentialsModelTest >> testTitle [
 	dialog askingHostname: 'github.com'. 
 	self openNonModal: dialog. 
 
-	self assert: dialog titleForWindow equals: 'Please log in to github.com'.
+	self assert: dialog windowTitle equals: 'Please log in to github.com'.
 ]
diff --git a/Iceberg-UI-Tests/IceTipPresenterMetaTest.class.st b/Iceberg-UI-Tests/IceTipPresenterMetaTest.class.st
@@ -96,19 +96,18 @@ IceTipPresenterMetaTest >> testDefaultSpecDoesntUsePragma [
 { #category : 'tests' }
 IceTipPresenterMetaTest >> testDoNotImplementDiscouragedSelectors [
 
-	"Either instance or class-side, the old #title is named #titleForWindow in inst-side."
-	self assertEmpty: (self presenterClassesDefining: #title isMeta: true).
-	self assertEmpty: (self presenterClassesDefining: #title isMeta: false).
+	"Either instance the old #title is named #windowTitle in inst-side."
+	self assertEmpty: (self presenterClassesDefining: #windowTitle isMeta: true).
 
-	"The #icon is called #iconForWindow in IceTip UI."
-	self assertEmpty: (self presenterClassesDefining: #icon isMeta: true).
+	"The #icon is called #windowIcon in IceTip UI."
+	self assertEmpty: (self presenterClassesDefining: #windowIcon isMeta: true).
 
 	"These methods are not yet deprecated via pragma, but discouraged in Spec2."
 	self assertEmpty: (self presenterClassesDefining: #initialExtent isMeta: false).
 	self assertEmpty: (self presenterClassesDefining: #initializeWidgets isMeta: false).
 	self assertEmpty: (self presenterClassesDefining: #initializePresenter isMeta: false).
 
-	self assertEmpty: (self presenterClassesDefining: #windowIcon isMeta: false).
+
 
 
 ]