Make the height of the paginator in a SpMillerPaginatorPresenter 20 pixels high explicitly #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixels high explicitly.
estebanlm
requested changes
Nov 3, 2025
Member
estebanlm
left a comment
estebanlm
left a comment
There was a problem hiding this comment.
I am sorry, I do not like this change. It is not fixing a problem (which seems to be calculating the height of a non-expanded row in a box layout) and instead is assigning a fixed (hardcoded) height to it which is not the case.
So, we need to determine why the paginator is not getting the right height and that may be for two reasons:
- the box layout fails somehow to calculate it.
- is the paginator component who is not declaring correctly its requested height (but this was working before your changes to the layout, so no idea :) ).
Contributor
Author
|
No worries. I will investigate it further. It is hard to debug because box layouts are used everywhere. |
Contributor
Author
|
This PR is not relevant anymore after @estebanlm's review comments. It has been replaced by #1843. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1830.
Here is the result after the fix. See inside the green circle.
All Spec tests have been run: