Skip to content

Conversation

@guillep
Copy link
Contributor

@guillep guillep commented Aug 29, 2025

Many extesions are:

  • tests extending existing test classes that can be either integrated in the extended class or put in their own class
  • extensions that could be integrated in the extended class but maybe were not because of historical reasons
  • extensions that are used in a single place, have only that single use case, and can just be inlined in the caller

This PR is a follow up of pharo-project/pharo#18501 that solves many unjustified extensions using the simple heuristics above:

  • move to the extended class
  • inline in caller
  • put in their own class

WARNING ⚠️ Depends on pharo-project/pharo#18501 and should be integrated after it

@estebanlm
Copy link
Member

I disagree with the removal of asValueHolder (because the replacement lacks the flexibility of it), but the rest is fine.

@estebanlm
Copy link
Member

tag is because I'm waiting for the other side.

@jecisc
Copy link
Member

jecisc commented Sep 22, 2025

Since this PR is in discussion, I opened another one with a subset of the changes: #1821

The goal of this PR is to just remove the methods overriding methods from the pharo repository

@estebanlm
Copy link
Member

so, we should now close this ?

@jecisc
Copy link
Member

jecisc commented Nov 3, 2025

Some things should still be integrated. But a decision needs to be taken for the #asValueHolder.

I find it easier to us #asValueHolder personally as Esteban

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants