Repository navigation
fix(pub_sub): escape channel and payload when rebuilding LISTEN/NOTIFY - #1763
Merged
Merged
Conversation
The parser decodes `NOTIFY chan, 'it''s here'` into the payload `it's here`, and the pub/sub listener interpolated it back into SQL without escaping, sending `NOTIFY "chan", 'it's here'` to the server: a syntax error. Escape the payload with quote_literal and the channel with escape_identifier (a `"` in a quoted channel name broke LISTEN, UNLISTEN and NOTIFY the same way).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
added this pull request to the merge queue
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser decodes
NOTIFY chan, 'it''s here'into the payloadit's here, and the pub/sub listener interpolated it back into SQL without escaping, sendingNOTIFY "chan", 'it's here'to the server: a syntax error. Escape the payload with quote_literal and the channel with escape_identifier (a"in a quoted channel name broke LISTEN, UNLISTEN and NOTIFY the same way).