Skip to content

validate passthrough passwords before creating pools - #1762

Closed
murex971 wants to merge 2 commits into
mainfrom
murex-bad-pwd
Closed

murex971 wants to merge 2 commits into
mainfrom
murex-bad-pwd

Conversation

@murex971

@murex971 murex971 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/databases.rs 91.22% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@levkk

levkk commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Oh woops, we both worked on this one 🤣 . My PR: #1760

We both came up with the same solution, which is cool! Mine does have a throttle to make sure a bunch of clients connecting at the same time don't all connect to the DB as well, but otherwise it's pretty close. I'm refactoring some stuff / fixing a bug in mine, but we could merge these together or maybe you'd want to take this one over? Up to you.

@levkk

levkk commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

I ended up going with something super complicated to make debounce/throttling work....

@murex971

murex971 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

ah! cool
we can close this and issue now ig

@murex971 murex971 closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Auth] Passthrough with bad password blocks pool

2 participants