Repository navigation
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
reviewed
Oct 5, 2026
| MultiStatementSafety, | ||
|
|
||
| #[error("SET ... FROM CURRENT is not supported")] | ||
| SetFromCurrent, |
Collaborator
There was a problem hiding this comment.
I don't think we need to raise this error. This is a no-op as far as I can tell, since the value of the parameter doesn't change. This is equivalent to SHOW param and SET param TO value_returned_by_show.
We could probably just pass it through as Command::Query.
Contributor
Author
There was a problem hiding this comment.
Makes sense, it's a no-op on the server. Changed it to pass through as Command::Query like SET TRANSACTION, and dropped the error.
SET ... FROM CURRENT sets a parameter to its current value, so it doesn't change session state. Route it like SET TRANSACTION instead of returning UnsupportedSetKind.
BABTUNA
force-pushed
the
fix/reset-all-multi-statement-panic
branch
from
October 10, 2026 00:39
b60b97f to
0568106
Compare
BABTUNA
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1729, from the review here.
SET x FROM CURRENTsets a parameter to its current value, so it doesn't change session state. It now passes through asCommand::QuerylikeSET TRANSACTIONinstead of returningUnsupportedSetKind. In a multi-statement query it's still split out and handled on its own.Added
test_set_from_current_passthroughcovering both cases.