feat: load cookie_secret from external-secrets - #19
Open
siryur wants to merge 2 commits into
Open
Conversation
cookie_secret previously had two sources: an inline value in control.config.auth, or a random key the chart generates and reuses via a lookup call. Neither let users manage the value through the external-secrets operator, which pgdogdev/helm already supports for its own secrets via templates/externalsecret.yaml. Add control.externalSecrets, mirroring that chart's block, plus a templates/externalsecret.yaml that renders an ExternalSecret when enabled. Its target Secret name is shared with the chart's existing lookup-based cookie_secret resolution (in secrets.yaml and configmap.yaml), so a synced cookie_secret key flows into control.toml exactly like the auto-generated case does, and the chart skips generating its own random secret to avoid ownership conflicts with the ExternalSecret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cookie_secret previously had two sources: an inline value in control.config.auth, or a random key the chart generates and reuses via a lookup call. Neither let users manage the value through the external-secrets operator, which pgdogdev/helm already supports for its own secrets via templates/externalsecret.yaml.
Add control.externalSecrets, mirroring that chart's block, plus a templates/externalsecret.yaml that renders an ExternalSecret when enabled. Its target Secret name is shared with the chart's existing lookup-based cookie_secret resolution (in secrets.yaml and configmap.yaml), so a synced cookie_secret key flows into control.toml exactly like the auto-generated case does, and the chart skips generating its own random secret to avoid ownership conflicts with the ExternalSecret.
Fix #18