feat(infra): add Azure Monitor Private Link Scope for network isolation#302
Merged
feat(infra): add Azure Monitor Private Link Scope for network isolation#302
Conversation
b2b725f to
0ac5a5b
Compare
- Add AMPLS resource scoped to Log Analytics Workspace and App Insights - Create monitoring subnet (snet-monitoring, 10.0.5.0/24) - Add NSG rule AllowMonitoringOutbound (priority 140) - Create 4 private DNS zones for monitor, OMS, ODS, and agent service - Deploy private endpoint pe-ampls-* with all 5 DNS zones (4 new + blob) - Disable public ingestion/query on Log Analytics and App Insights Part of #296 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0ac5a5b to
1090cdb
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Azure Monitor Private Link Scope (AMPLS) to route all monitoring traffic through the VNet, eliminating the last publicly accessible data-plane endpoints.
Why
Log Analytics Workspace and Application Insights were the only two resources still publicly accessible. Telemetry containing application logs (MR content, code review context, Copilot interactions) was traversing the public internet.
Changes
infra/variables-apps.tf: Newmonitoring_subnet_prefixvariable (10.0.5.0/24)infra/networking.tf: Monitoring subnet (snet-monitoring) + NSG ruleAllowMonitoringOutbound(priority 140)infra/monitoring.tf:PrivateOnlyingestion/query access modespe-ampls-*with DNS zone groupHow to test
cd infra && terraform init -backend=false && terraform validateReview notes
PrivateOnlyaccess modes)Part of #296