Skip to content

Set longer fetch timeout for SHA/tag response #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

janbrasna
Copy link

Resolves #419

Server does the work anyways, so it's too bad the client raises an error earlier than the results arrive.

(This also tweaks some wording to make the eventual corner cases more comprehensible.)

Copy link

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

But of course we need an r+ from Peter to really count :)

@janbrasna
Copy link
Author

I have also included some general wording/formatting tweaks around error messaging with this, as I was often mislead by the errors reported when investigating this. Should be generally uncontroversial, here's one example I though could benefit from formatting to separate the actual content from the message:

(before:)
Screenshot 2025-04-28 at 13 49 56

(after:)
Screenshot 2025-04-27 at 3 12 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client timeout shorter than server timeout
2 participants