Support GNU Lightning 2.2.0 #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, we crash, at least unless we provide the required user-supplied buffers.
It seems that this was probably always required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GNU Lightning 2.2.0, including support for Apple's M1 architecture, was released on 16 Nov 2022. The current PR aims to support that version within
lightning-sys.This PR might remain in draft state for a few weeks or even longer; I wanted to checkpoint my current progress, but there are things left to do.
Things to do in this PR
cargo teston Darwin aarch64 (macOS on M1)cargo teston Darwin x86-64 (macOS on x86-64)lightning-sysmacros to support newgetarg/arg/putarg/pusharg"flavors" with fewer manual overrides