Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct light button active colour #418

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Correct light button active colour #418

merged 1 commit into from
Mar 14, 2025

Conversation

mitkins
Copy link
Collaborator

@mitkins mitkins commented Mar 14, 2025

No description provided.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (99ad16a) to head (4de594c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          37       37           
  Lines        1592     1592           
=======================================
  Hits         1427     1427           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added text-white class to the light button variant's active state in dark mode to ensure proper text contrast when clicked.

  • Modified assets/default.css to add text-white class to .pc-button--light active state in dark mode for better accessibility
  • Change maintains visual consistency with existing dark mode button styles
  • Improves button usability by ensuring text remains visible during click interactions

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@mitkins mitkins merged commit a4cfab4 into main Mar 14, 2025
3 checks passed
@mitkins mitkins deleted the tailwind4_fixes branch March 14, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant