Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CSS anomolies after Tailwind 4 upgrade #417

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Conversation

mitkins
Copy link
Collaborator

@mitkins mitkins commented Mar 14, 2025

  • Light button text wasn't right on hover (in dark mode)
  • Table dividers set to border-gray-200 instead of currentColor
  • Removed some unnecessary classes

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses CSS styling anomalies following the Tailwind 4 upgrade, focusing on button and table component visual improvements.

  • Fixed dark mode hover text color for light buttons by adding dark:hover:text-white class
  • Changed table divider color from currentColor to border-gray-200 for better visibility
  • Removed redundant border-transparent class from pure-white button variant since it already has border-white
  • Improves visual consistency across light and dark modes

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@mitkins mitkins merged commit 0aadfd7 into main Mar 14, 2025
3 checks passed
@mitkins mitkins deleted the tailwind4_fixes branch March 14, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant