Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement used_input? instead of phx-feedback-for #382

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

mitkins
Copy link
Collaborator

@mitkins mitkins commented Dec 10, 2024

Moves Petal Components away from phx-feedback-for and phx-no-feedback

Also merges the contents from this PR - #341. Thanks @joepstender.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 98.23789% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.57%. Comparing base (2778d68) to head (de0e34b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/petal_components/input.ex 0.00% 2 Missing ⚠️
lib/petal_components/form.ex 99.14% 1 Missing ⚠️
lib/petal_components/icons/svg.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   89.77%   89.57%   -0.21%     
==========================================
  Files          37       37              
  Lines        1634     1582      -52     
==========================================
- Hits         1467     1417      -50     
+ Misses        167      165       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitkins mitkins merged commit 025faf3 into main Dec 11, 2024
3 checks passed
@mitkins mitkins deleted the live_view_1.0 branch December 11, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant