fix: Add multipart form-data support for Laravel HTTP server#200
fix: Add multipart form-data support for Laravel HTTP server#200homiedopie wants to merge 4 commits intopestphp:4.xfrom
Conversation
|
Good day, I detect an error when you don't select a file: The browser send a file with the header Additionally, I notice that other corner cases like when the file is greater that the max file size defined in the INI file (UPLOAD_ERR_INI_SIZE and UPLOAD_ERR_FORM_SIZE) |
|
@gtg-bantonio Thanks for the feedback. Ill check it out and will add some test as well! |
|
@gtg-bantonio I addressed it on the new fixes I have added. Can you please check on your end? Thank you! |
7527459 to
52ad5dd
Compare
52ad5dd to
6e72b2e
Compare
|
I found another bug, with nested indexed fields in a linear sequence: The decoded data should be (in PHP array notation) [
'extra' => 'Test',
'data' => [
0 => [
'field1' => '1',
'field2' => '1',
],
1 => [
'field1' => '2',
'field2' => '0',
],
],
]But instead the parser returns: [
'extra' => 'Test',
'data' => [
0 => [
'field1' => '1',
'field2' => ['0', '1'],
],
1 => [
'field1' => '2',
'field2' => '0',
],
],
] |
|
Can I ask, how is this PR different from the other PR #177 ? Confused on which one to follow. |
|
@akulmehta in this PR, the library that use is the |
|
@gtg-bantonio - thanks for explaining it! I addressed the issue already and separated the test (dedicated to multipart upload/parameters) |
|
I can't found another error with our full script, and the tests and code are better that mine, so I will close my PR in favor of yours |
b5a29af to
f0400c0
Compare
|
@gtg-bantonio - Thanks again for your help! wouldnt be possible without your guidance and inputs! |
Problem
Requestobject.Fix
UploadedFileinstances.Test
Verification
Note
Related
Related #177 - Thanks to @gtg-bantonio
Fixes #1495