forked from samcamwilliams/HyperBEAM
-
Notifications
You must be signed in to change notification settings - Fork 69
fix: HTTP client #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noahlevenson
wants to merge
8
commits into
edge
Choose a base branch
from
fix/http-client
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: HTTP client #477
+101
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahlevenson
commented
Sep 18, 2025
| req(Args, ReestablishedConnection, Opts) -> | ||
| case hb_opts:get(http_client, gun, Opts) of | ||
| gun -> gun_req(Args, ReestablishedConnection, Opts); | ||
| gun -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference for #481
noahlevenson
commented
Sep 18, 2025
| Reply -> | ||
| Reply | ||
| end; | ||
| Reply = {_Ok, StatusCode, RedirectRes, _} -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference for #481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of changes which fix HTTP client bugs, implement correct SSL/TLS semantics, and make our two underlying HTTP client libraries --
gunandhttpc-- match one another's behavior.Changes:
gunnow automatically follows 3xx redirects, matchinghttpcbehaviorhttp_follow_redirectsoption toggles autoredirect behavior, works for bothgunandhttpcgun_max_redirectsoption mitigates redirect attacks on our bespokegunredirect follower (httpchandles redirects out of the box and does not expose a twiddleable param)Now, you should be able to do something like this:
hb_http_client:req(#{path => "/", method => <<"GET">>, peer => "http://nytimes.com", headers => #{}, body => <<>>}, #{http_client => gun}).And it should just work. That request actually follows 2 redirects -- first, to the TLS encrypted
https://URL, and then to thewwwsubdomain. So just for fun, if you twiddle thegun_max_redirectsoption, you can observe the client only follow the first redirect and return the 301:hb_http_client:req(#{path => "/", method => <<"GET">>, peer => "http://nytimes.com", headers => #{}, body => <<>>}, #{http_client => gun, gun_max_redirects => 1}).