fix: normalize commitments after [email protected] execution
#473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthks
force-pushed
the
fix/lua-commitment-normalization
branch
from
2775b4e to
30b8f67
Compare
Lucifer0x17
force-pushed
the
fix/lua-commitment-normalization
branch
2 times, most recently
from
7478894 to
acaa76b
Compare
Collaborator
Author
|
Merged in #529. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
[email protected]execution flow to ensure that the resulting message contains a normalized set of commitments. Previously, in flows where the result of an execution is a message relating to thebaseinput, changing values from inside Lua could lead to unverifiable outputs.