PER_5831: Update dependencies and selenium test #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes performed in branch PER_5831
Summary:
selenium-webdriverAPI.webrick,base64) required for Ruby 3.4+.Files changed:
package.json— bumpedtodomvc-app-cssto ^2.4.3 and@percy/clito ^1.31.2Gemfile— bumpedselenium-webdriverto ~> 4.36.0; addedwebrickandbase64gemstests/todo.rb— updated Selenium driver initialization to useoptions:README.md— added Versions section reflecting new versions usedGemfile.lock,package-lock.json— updated by package managersSteps performed:
web-t && make testto reproduce existing behavior and capture initial errors.package.json,Gemfile).npm installandbundle install/bundle updateto install updated packages intonode_modulesandvendor/bundle.webrickandbase64toGemfile.tests/todo.rbto useSelenium::WebDriver.for(:firefox, options: options)to match selenium-webdriver 4.36.0 API.PER_5831, committed changes, and pushed to origin.Percy builds created during verification:
Notes / Rationale:
percy-seleniumlatest available is 1.1.1; no upgrade needed there.options:. Adjusted test accordingly.webrickandbase64ensures compatibility with Ruby 3.4+ where these are no longer bundled by default.How to reproduce locally:
web-tin your shell (already present in this environment).make installto set up node and Ruby dependencies.make testto execute tests and create Percy snapshots.