PG-1710 Decrypt partial WAL segments when archvining them #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (81.76%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #496 +/- ##
==================================================
Coverage 81.75% 81.76%
==================================================
Files 24 24
Lines 2987 2988 +1
Branches 485 485
==================================================
+ Hits 2442 2443 +1
Misses 444 444
Partials 101 101
🚀 New features to boost your workflow:
|
jeltz
force-pushed
the
tde/archive-restore-partial
branch
from
b69f88a to
4ca2d67
Compare
dAdAbird
requested changes
Jul 30, 2025
| @@ -16,7 +16,8 @@ | |||
| static bool | |||
| is_segment(const char *filename) | |||
| { | |||
| return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN && filename[XLOG_FNAME_LEN] == '\0'; | |||
| return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN && | |||
| (filename[XLOG_FNAME_LEN] == '\0' && strcmp(filename + XLOG_FNAME_LEN, ".partial")); | |||
There was a problem hiding this comment.
shouldn't this be
return strspn(filename, "0123456789ABCDEF") == XLOG_FNAME_LEN &&
(filename[XLOG_FNAME_LEN] == '\0' || strcmp(filename + XLOG_FNAME_LEN, ".partial") == 0);and the same in contrib/pg_tde/src/bin/pg_tde_restore_encrypt.c
There was a problem hiding this comment.
Yeah, I was interrupted in the middle of writing the code and did not check it before submitting the PR. My apologies. :(
While the restore_command will never be called for partial WAL segments we should sitll make sure to decrypt them when archiving so a sysadmin manually could use them. As the comemnt explains we also add the same logic to the restore command for symmetry and if someone ever would call it manually or PostgreSQL would add support for restoring partial WAL segments. If you want to learn more about partial WAL segments read the comment for CleanupAfterArchiveRecovery().
jeltz
force-pushed
the
tde/archive-restore-partial
branch
from
4ca2d67 to
7a01d20
Compare
dAdAbird
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the restore_command will never be called for partial WAL segments we should sitll make sure to decrypt them when archiving so a sysadmin manually could use them. As the comemnt explains we also add the same logic to the restore command for symmetry and if someone ever would call it manually or PostgreSQL would add support for restoring partial WAL segments.
If you want to learn more about partial WAL segments read the comment for CleanupAfterArchiveRecovery().