Updated principal-key/features/functions.md based on AA feedback #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In set-principal-key.md: * updated with correct code example using set_server_key_using_global parameter * updated note to reflect correct config In features.md: * Removed temporary tables feature to clear confusion, removed logical replication mention, removed WAL encryption as a feature. In functions.md: * Added ON FUNCTION for grant/revoke execution * Modified sensitive info bolded paragraph to important note * Small modifications to notes display, title cases and text fixes * added note to Add or modify Vault providers for keeping the same principal key. * Added warning for WAL in pg_tde_create_key_using_global_key_provider In general: * Removed all logical replication mentions except the FAQ and in RC2 release note.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #441 +/- ##
=================================================
Coverage ? 84.67%
=================================================
Files ? 21
Lines ? 2591
Branches ? 402
=================================================
Hits ? 2194
Misses ? 316
Partials ? 81
🚀 New features to boost your workflow:
|
Andriciuc
changed the title
* fixed keyfile to key file and keyfile proviers to key file providers * updated remote config options to file paths for specific param warning note.
| @@ -9,16 +9,13 @@ The following features are available for the extension: | |||
| * Data tables | |||
| * Index data for encrypted tables | |||
| * TOAST tables | |||
| * Temporary tables created during database operations | |||
There was a problem hiding this comment.
It's fine to leave "Temporary tables" in here since we do encrypt those. It's just that everything here is "created during database operations" so I didn't understand that part :)
There was a problem hiding this comment.
Initially I wanted to write: Temporary tables created during queries on encrypted tables are also encrypted
I am thinking that perhaps this is just a standard PostgreSQL feature, so maybe I should remove it, thoughts?
There was a problem hiding this comment.
Temporary tables is a standard feature that we can encrypt. You're thinking about temporary files created during query execution. those are not (yet) encrypted.
fixed keyfile to key file for title Removed warning notes regarding remote config options.
restructured and improved paragraphs create key and creates keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In set-principal-key.md:
In features.md:
In functions.md:
In general: