Fix broken reuse of deleted entries in key map file #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we tried to check if
flags & MAP_ENTRY_EMPTY
was true when searching for empty entries the code was broken sincex & 0
always is false. We fix this by refactoringpg_tde_read_one_map_entry()
so the filtering of the entries is done outside the function. This make implementing search for empty entries much easier.