Skip to content

Fix some documentation pages after key management functions renaming #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

artemgavrilov
Copy link
Collaborator

Fix some documentation pages after key management functions renaming

@artemgavrilov artemgavrilov changed the title Do missing renamings in documentation Fix some documentation pages after key management functions renaming Apr 17, 2025
@@ -287,11 +287,11 @@ These functions display the provider type and configuration details, but won't s

`Pg_tde` implements access control based on execution rights on the administration functions.

For provider administration, it provides two pair of functions:
For keys and providers administration, it provides two pair of functions:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have permission differentiation for key and providers administration. Is it something that we are planning?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but maybe we should look closer at why and how we actually want multi-tenancy to work because the ability to create key providers is actually quite dnagerous.


Also, the `pg_tde_(grant/revoke)_key_management_to_role` function deals with only the specific permission for the above function:
// TODO: We don't have such permissions subset
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this todo to revisit this topic

@artemgavrilov artemgavrilov marked this pull request as ready for review April 17, 2025 14:53
@artemgavrilov artemgavrilov requested a review from jeltz April 17, 2025 14:53

`pg_tde_global_principal_key_info(‘PG_TDE_GLOBAL')` does the same for the server key.
`pg_tde_server_key_info('PG_TDE_GLOBAL')` does the same for the server key.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PG_TDE_GLOBAL does not exist anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't have arguments at all, so removed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (40c32b2) to head (2eff248).
Report is 6 commits behind head on TDE_REL_17_STABLE.

❌ Your project status has failed because the head coverage (76.09%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #229      +/-   ##
=====================================================
+ Coverage              75.94%   76.09%   +0.15%     
=====================================================
  Files                     23       23              
  Lines                   2523     2523              
  Branches                 394      394              
=====================================================
+ Hits                    1916     1920       +4     
+ Misses                   530      526       -4     
  Partials                  77       77              
Components Coverage Δ
access 71.52% <ø> (ø)
catalog 86.06% <ø> (+0.46%) ⬆️
common 92.50% <ø> (ø)
encryption 71.90% <ø> (ø)
keyring 69.87% <ø> (ø)
src 52.96% <ø> (ø)
smgr 96.77% <ø> (ø)
transam 95.91% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemgavrilov artemgavrilov requested a review from jeltz April 18, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants