-
Notifications
You must be signed in to change notification settings - Fork 8
Fix some documentation pages after key management functions renaming #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: TDE_REL_17_STABLE
Are you sure you want to change the base?
Conversation
@@ -287,11 +287,11 @@ These functions display the provider type and configuration details, but won't s | |||
|
|||
`Pg_tde` implements access control based on execution rights on the administration functions. | |||
|
|||
For provider administration, it provides two pair of functions: | |||
For keys and providers administration, it provides two pair of functions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have permission differentiation for key and providers administration. Is it something that we are planning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but maybe we should look closer at why and how we actually want multi-tenancy to work because the ability to create key providers is actually quite dnagerous.
|
||
Also, the `pg_tde_(grant/revoke)_key_management_to_role` function deals with only the specific permission for the above function: | ||
// TODO: We don't have such permissions subset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this todo to revisit this topic
|
||
`pg_tde_global_principal_key_info(‘PG_TDE_GLOBAL')` does the same for the server key. | ||
`pg_tde_server_key_info('PG_TDE_GLOBAL')` does the same for the server key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PG_TDE_GLOBAL
does not exist anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function doesn't have arguments at all, so removed.
2ec0654
to
2eff248
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (76.09%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #229 +/- ##
=====================================================
+ Coverage 75.94% 76.09% +0.15%
=====================================================
Files 23 23
Lines 2523 2523
Branches 394 394
=====================================================
+ Hits 1916 1920 +4
+ Misses 530 526 -4
Partials 77 77
🚀 New features to boost your workflow:
|
Fix some documentation pages after key management functions renaming