K8SPS-413: replace initImage with initContainer #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
jvpasinatto,
eleo007,
valmiranogueira,
hors,
egegunes,
nmarukovich and
gkech
as code owners
hors
requested changes
Aug 13, 2025
pull-request-size
bot
added
size/XXL
egegunes
previously approved these changes
Aug 20, 2025
gkech
reviewed
Aug 21, 2025
pkg/k8s/init_image.go
Outdated
| return image, nil | ||
| } | ||
| if cr.CompareVersion("0.12.0") < 0 && cr.Spec.InitImage == "" { |
There was a problem hiding this comment.
Maybe we can introduce some //nolint:staticcheck where InitImage is used since the linter is a required step for merging and this will keep complaining.
gkech
previously approved these changes
Aug 21, 2025
nmarukovich
previously approved these changes
Aug 21, 2025
gkech
previously approved these changes
Aug 26, 2025
nmarukovich
previously approved these changes
Aug 26, 2025
gkech
previously approved these changes
Aug 26, 2025
egegunes
approved these changes
Aug 26, 2025
gkech
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-413
DESCRIPTION
This PR replaces
.spec.initImagefield with.spec.initContainersection that matches the pxc-operatorHelm chart PR: percona/percona-helm-charts#615
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability