Skip to content

K8SPS-269 add labels for all objects created by operator #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

K8SPS-269 add labels for all objects created by operator #989

wants to merge 20 commits into from
+33 −293

Conversation

nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Aug 8, 2025 •
edited
Loading

K8SPS-269 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
I rechecked all objects created by operator and only cm doesn't have labels. The labels to config map were added in this PR.
metadata:
creationTimestamp: "2025-08-18T08:08:05Z"
labels:
app.kubernetes.io/component: database
app.kubernetes.io/instance: cluster1
app.kubernetes.io/managed-by: percona-server-mysql-operator
app.kubernetes.io/name: auto-cluster1-mysql
app.kubernetes.io/part-of: percona-server
app.kubernetes.io/version: v0.11.0

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Aug 8, 2025
@hors hors added this to the v0.12.0 milestone Aug 8, 2025
hors
hors requested changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmarukovich please add to the PR description which labels were added

@nmarukovich nmarukovich requested a review from hors August 18, 2025 08:14
gkech
gkech previously approved these changes Aug 20, 2025
View reviewed changes
gkech
gkech reviewed Aug 20, 2025
View reviewed changes
gkech
gkech reviewed Aug 20, 2025
View reviewed changes
@gkech gkech self-requested a review August 20, 2025 08:56
egegunes
egegunes reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@egegunes egegunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check @gkech's comments

@nmarukovich nmarukovich requested a review from egegunes August 22, 2025 10:49
gkech
gkech previously approved these changes Aug 25, 2025
View reviewed changes
@nmarukovich nmarukovich requested a review from gkech August 26, 2025 09:26
hors
hors requested changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we need to have this label in all objects :(
app.kubernetes.io/version: v0.11.0

Will the operator update it as soon as we update the image or when we change the crVersion?

Can it cause any additional restarts/problems?

@egegunes WDYT?

egegunes
egegunes reviewed Aug 27, 2025
View reviewed changes
pkg/k8s/configmap.go Outdated
},
Data: map[string]string{
filename: data,
},
}
if cr.CompareVersion("0.12.0") >= 0 {
cm.Labels = naming.Labels(name, cr.Name, "percona-server", "database")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this function used for all config maps? is it okay to set database as component in every config map?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one do you think it should be put here?

@egegunes
Copy link
Contributor

I am not sure that we need to have this label in all objects :( app.kubernetes.io/version: v0.11.0

Will the operator update it as soon as we update the image or when we change the crVersion?

Can it cause any additional restarts/problems?

@egegunes WDYT?

@hors I don't see anything that adds version label in this PR. I think it's already in main.

@hors
Copy link
Collaborator

hors commented Aug 27, 2025

I am not sure that we need to have this label in all objects :( app.kubernetes.io/version: v0.11.0
Will the operator update it as soon as we update the image or when we change the crVersion?
Can it cause any additional restarts/problems?
@egegunes WDYT?

@hors I don't see anything that adds version label in this PR. I think it's already in main.

I know, but I just saw it when I reviewed it :(

@nmarukovich
Copy link
Contributor Author

I am not sure that we need to have this label in all objects :( app.kubernetes.io/version: v0.11.0
Will the operator update it as soon as we update the image or when we change the crVersion?
Can it cause any additional restarts/problems?
@egegunes WDYT?

@hors I don't see anything that adds version label in this PR. I think it's already in main.

I know, but I just saw it when I reviewed it :(

As we discussed, I will fix it in this PR

@pull-request-size pull-request-size bot added size/M 30-99 lines and removed size/S 10-29 lines labels Aug 29, 2025
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Aug 29, 2025
@nmarukovich nmarukovich requested review from hors and egegunes August 29, 2025 12:28
@JNKPercona
Copy link
Collaborator

Test name Status
version-service skipped
async-ignore-annotations skipped
auto-config skipped
config skipped
config-router skipped
demand-backup skipped
async-data-at-rest-encryption skipped
gr-data-at-rest-encryption skipped
gr-demand-backup skipped
gr-demand-backup-haproxy skipped
gr-finalizer skipped
gr-haproxy skipped
gr-ignore-annotations skipped
gr-init-deploy skipped
gr-one-pod skipped
gr-recreate skipped
gr-scaling skipped
gr-scheduled-backup skipped
gr-security-context skipped
gr-self-healing skipped
gr-tls-cert-manager skipped
gr-users skipped
haproxy skipped
init-deploy skipped
limits skipped
monitoring skipped
one-pod skipped
operator-self-healing skipped
recreate skipped
scaling skipped
scheduled-backup skipped
service-per-pod skipped
sidecars skipped
smart-update skipped
storage skipped
tls-cert-manager skipped
users skipped
pvc-resize skipped
We run 0 out of 38

commit: df96235
image: perconalab/percona-server-mysql-operator:PR-989-df96235d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooknull pooknull Awaiting requested review from pooknull pooknull is a code owner

@gkech gkech Awaiting requested review from gkech gkech is a code owner

@jvpasinatto jvpasinatto Awaiting requested review from jvpasinatto jvpasinatto is a code owner

@eleo007 eleo007 Awaiting requested review from eleo007 eleo007 is a code owner

@valmiranogueira valmiranogueira Awaiting requested review from valmiranogueira valmiranogueira is a code owner

@hors hors Awaiting requested review from hors hors is a code owner

@egegunes egegunes Awaiting requested review from egegunes egegunes is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/L 100-499 lines
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nmarukovich @egegunes @hors @JNKPercona @gkech