Skip to content

K8SPS-400: custom options for xtrabackup, xbstream, xbcloud #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Aug 6, 2025

K8SPS-400 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPS-400

DESCRIPTION

Problem:
In our backups and restoration process we rely on xtrabackup, xbstream and xbcloud. Not always default options for these tools are optimal.

Solution:
Add containerOptions section to ps-backup, ps-restore and ps resources.

containerOptions:
  env:
  - name: VERIFY_TLS
    value: "false"
  - name: XB_USE_MEMORY
    value: "2GB"
  args:
    xtrabackup:
    - "--someflag=abc"
    - "--someotherflag=def"
    xbcloud:
    - "--someflag=abc"
    - "--someotherflag=def"
    xbstream:
    - "--someflag=abc"
    - "--someotherflag=def"

If containerOptions specified in both ps-backup/ps-restore and ps, values from ps-backup/ps-restore will be used.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XXL 1000+ lines label Aug 6, 2025
@pooknull pooknull added this to the v0.12.0 milestone Aug 6, 2025
@JNKPercona
Copy link
Collaborator

Test name Status
version-service passed
async-ignore-annotations passed
auto-config passed
config passed
config-router passed
demand-backup passed
async-data-at-rest-encryption passed
gr-data-at-rest-encryption passed
gr-demand-backup passed
gr-demand-backup-haproxy passed
gr-finalizer passed
gr-haproxy passed
gr-ignore-annotations passed
gr-init-deploy passed
gr-one-pod passed
gr-recreate passed
gr-scaling passed
gr-scheduled-backup passed
gr-security-context passed
gr-self-healing passed
gr-tls-cert-manager passed
gr-users passed
haproxy passed
init-deploy passed
limits passed
monitoring passed
one-pod passed
operator-self-healing passed
recreate passed
scaling passed
scheduled-backup passed
service-per-pod passed
sidecars passed
smart-update passed
storage passed
tls-cert-manager passed
users passed
pvc-resize passed
We run 38 out of 38

commit: fb6e2fa
image: perconalab/percona-server-mysql-operator:PR-986-fb6e2fa0

Copy link
Collaborator

@hors hors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooknull please add e2e test for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants