K8SPS-465: add liveness and readiness probes to haproxy #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
jvpasinatto,
eleo007,
valmiranogueira,
hors and
egegunes
as code owners
hors
previously approved these changes
Aug 15, 2025
gkech
reviewed
Aug 19, 2025
pkg/haproxy/haproxy.go
Outdated
Comment on lines
324
to
325
| ReadinessProbe: &readinessProbe, | ||
| LivenessProbe: &livenessProbe, |
There was a problem hiding this comment.
Should we have a version check for adding these? If I'm not mistaken, we discussed that at some point that we should for ps operator.
pkg/haproxy/haproxy.go
Outdated
Comment on lines
294
to
314
| readinessProbe := spec.ReadinessProbe | ||
| readinessProbe.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/opt/percona/haproxy_readiness_check.sh"}, | ||
| } | ||
| livenessProbe := spec.LivenessProbe | ||
| livenessProbe.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/opt/percona/haproxy_liveness_check.sh"}, | ||
| } | ||
|
|
||
| probsEnvs := []corev1.EnvVar{ | ||
| { | ||
| Name: "LIVENESS_CHECK_TIMEOUT", | ||
| Value: fmt.Sprint(livenessProbe.TimeoutSeconds), | ||
| }, | ||
| { | ||
| Name: "READINESS_CHECK_TIMEOUT", | ||
| Value: fmt.Sprint(readinessProbe.TimeoutSeconds), | ||
| }, | ||
| } | ||
| env = append(env, probsEnvs...) | ||
|
|
There was a problem hiding this comment.
We can add a test case for the probes in haproxy_test.go checking that the probe handlers have the right exec command, that the various seconds configs exist and also that the env vars used by the probe bash scripts are set up properly.
egegunes
reviewed
Aug 20, 2025
pkg/haproxy/haproxy.go
Outdated
Comment on lines
296
to
303
| readinessProbe = &spec.ReadinessProbe | ||
| readinessProbe.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/opt/percona/haproxy_readiness_check.sh"}, | ||
| } | ||
| livenessProbe = &spec.LivenessProbe | ||
| livenessProbe.Exec = &corev1.ExecAction{ | ||
| Command: []string{"/opt/percona/haproxy_liveness_check.sh"}, | ||
| } |
There was a problem hiding this comment.
i think we can use k8s.ExecProbe here
gkech
approved these changes
Aug 21, 2025
nmarukovich
approved these changes
Aug 21, 2025
commit: d7710be |
egegunes
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPS-465
DESCRIPTION
This PR adds liveness and readiness probes to haproxy pods
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability