Skip to content

PBM-1488 PITR will stop saving the oplog if the process of copying the oplog from the backup fails #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PBM-1488 PITR will stop saving the oplog if the process of copying the oplog from the backup fails #1163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pbm/slicer/slicer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ func (s *Slicer) Catchup(ctx context.Context) error {
err = s.copyReplsetOplog(ctx, rs)
if err != nil {
s.l.Error("copy oplog from %q backup: %v", lastBackup.Name, err)
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will produce oplog hole within PITR chunks for the whole duration of the backup procedure.

}
}
s.lastTS = rs.LastWriteTS
Expand Down
Loading