PMM-11673-fix-psmdb-configuration: fix configuration in api #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio-silva
previously approved these changes
Apr 20, 2023
Author
|
this task came back to me from QA and it turned out that the problem is not only FE, but also that BE returns an error (500) since we can check the configuration in two ways, I added another backup way to check the configuration from another api - dbclustersList and also, since the task (https://jira.percona.com/browse/PMM-11674) was small and it was convenient to do it in this PR, I added the addition of a default configuration |
added 2 commits
April 27, 2023 16:32
| @@ -0,0 +1,12 @@ | |||
| import { Databases } from 'app/percona/shared/core'; | |||
| export const PXCDefailtConfiguration = | |||
Collaborator
There was a problem hiding this comment.
Typo: PXCDefaultConfiguration
matejkubinec
approved these changes
Apr 27, 2023
fabio-silva
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-11673
the problem was in 500 server error, but we have two ways to get a configurations, so I added an extra way to check it
also the task (https://jira.percona.com/browse/PMM-11674) was added in this ticket