Calloutコンポーネントに閉じるボタンを追加します #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumink7
reviewed
Jan 21, 2025
packages/callout/_mixins.scss
Outdated
Comment on lines
43
to
49
| &:active, | ||
| &.--active { | ||
| visibility: visible; | ||
| opacity: 100%; | ||
| translate: 0 0; | ||
| transition: all 0.4s; | ||
| } |
There was a problem hiding this comment.
callout、表示されているのが基本のような気がするので、むしろ.--hiddenで非表示になるとかの方がいいのかも…？と思いましたがどうなんでしょうね？
There was a problem hiding this comment.
mtgでお話ししました
今回の変更ではボタンを追加するスペースを設定する、ということが目的でした。
calloutを非表示にするロジックについては利用者に委ねる方針に決定したため、関連スタイルは不要となりました。
piyoppi
reviewed
Jan 21, 2025
| <div className={wrapperClasses.join(' ')}> | ||
| <div | ||
| className={wrapperClasses.join(' ')} | ||
| aria-live="polite" |
There was a problem hiding this comment.
この属性が必要かどうかは、trailingに入るボタンによる効果に依るように見受けられるので、もしそうなら不要かなと思いました
There was a problem hiding this comment.
75e90b0 の削除忘れでした
ありがとうございます！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snackbarコンポーネントを参考に、calloutコンポーネントにcloseボタンを追加します。
bodyが1行だった場合に上下方向のズレが発生しますが、複数行になった際を考慮し上下中央揃えは追加せず、利用する際に追加してもらう方針としました。